chore: remove KT-69327 workaround - #27
Closed
IRus wants to merge 2 commits into
Closed
Conversation
The Kotlin/Native floating point parser bug is fixed as of Kotlin 2.4.10, so String.toFloat/toDouble no longer throw IndexOutOfBoundsException for inputs like "1e-". - Drop both catch (IndexOutOfBoundsException) blocks in YamlScalar - Re-enable the "1e-" case in YamlScalarTest on Native - Use _ for unused catch parameters Verified: 586 tests pass on macosArm64, iosSimulatorArm64, jvm, jsNode and wasmJsNode. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
Merged manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KT-69327 (Kotlin/Native floating point parser throwing
IndexOutOfBoundsExceptioninstead ofNumberFormatException) is fixed. The workaround is no longer needed on Kotlin 2.4.10.Changes
YamlNode.kt— removed bothcatch (e: IndexOutOfBoundsException)blocks fromtoFloatOrNullandtoDoubleOrNullYamlScalarTest.kt— removed theKotlinTarget.NATIVEbranch that disabled the1e-casee->_Verification
586 tests pass, 0 ignored, on:
macosArm64,iosSimulatorArm64,jvm,jsNode,wasmJsNode.linuxX64,linuxArm64andmingwX64cannot run on a macOS host — CI covers those.Note:
--tests '*YamlScalarTest*'does not filter Kotest on Native (the spec is silently skipped). Run the full target task.🤖 Generated with Claude Code