fix: restore reliable click-to-position cursor in 1.4.3 - #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare the stable winTerm 1.4.3 hotfix and restore reliable Click to position cursor behavior when normal pointer jitter occurs between button press and release.
This PR was created as a draft because automated interaction coverage and OS-injected real-window validation passed, but the required physical-mouse validation and the five clean prompt-lifecycle repetitions are still explicitly NOT RUN. GitHub records that the repository owner merged it at 2026-08-27 00:11:07 UTC before that manual gate completed. No
buildlabel was added; tag creation and release publication remain blocked on the gate.Related issues
No linked issue.
Detailed changes
Root cause
The Core correctly ignored selection-end updates when no selection existed, but Interactivity still treated each pointer move as a real selection change. That unrelated copy state then blocked release-time cursor repositioning.
Fix
ControlCore::SetEndSelectionPointreport whether it actually updated a selection.v1.4.3.Validation performed
Environment: Windows 11 x64, local Microsoft Terminal-compatible toolchain, Debug and Release x64.
*CursorReposition*tests: 11/11 passed.scripts/winterm/verify-version.ps1: passed.scripts/winterm/verify-branding.ps1: passed.scripts/winterm/test-visual-progress.ps1 -SourceOnly: passed.Checklist
CHANGELOG.md.Development-Changes.mdledger has been pushed with the final source SHA, link, summary, and checkpoint/release. (Wiki commit7a39d28b40015ed149093a6264dabe0892a2a323.)winterm-siteasset, or no screenshot was added. (No screenshot added.)winterm.exe, and Microsoft Terminal coexistence remain isolated.