fix some typos - #4
Open
robin4a4 wants to merge 1 commit into
Open
Conversation
robin4a4
commented
Nov 7, 2022
| @functools.wraps(func) | ||
| def compile_func(parser, token): | ||
| name, *bits = token.split_contents() | ||
| def compile_func(parser, compose_token): |
Collaborator
Author
There was a problem hiding this comment.
ça evite un warning de shadows name from outer scope, c'est pas grave dans ce cas la d'autant plus que tout est testé mais peut etre que pour une lib on veut éviter tous les soucis potentiels ?
Member
There was a problem hiding this comment.
C'est préfèrable de garder token ici, et de renommer l'autre maybe_token
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.