Skip to content

Potential fix for code scanning alert no. 2: Server-side request forgery #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SSMG4 merged 1 commit into from
Aug 23, 2026
Merged

Potential fix for code scanning alert no. 2: Server-side request forgery #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/server/proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,10 +237,22 @@
const rawQuery = req.url.includes('?') ? req.url.slice(req.url.indexOf('?') + 1) : '';
if (rawQuery) {
parsedTarget.search = parsedTarget.search ? `${parsedTarget.search}&${rawQuery}` : `?${rawQuery}`;
targetUrl = parsedTarget.href;
}

if (parsedTarget.protocol === 'http:') parsedTarget.protocol = 'https:';
if (parsedTarget.protocol !== 'https:') {
res.status(400).type('text').send('Only HTTP(S) targets are allowed.');
return;
}

if (isPrivateHostname(parsedTarget.hostname)) {
res.status(403).type('text').send('Proxying to private or internal addresses is not allowed.');
return;
}

targetUrl = parsedTarget.href;

if (parsedTarget.protocol !== 'http:' && parsedTarget.protocol !== 'https:') {

Check failure on line 255 in src/server/proxy.ts

View workflow job for this annotation

GitHub Actions / Lint, Type-check & Build 

This comparison appears to be unintentional because the types '"https:"' and '"http:"' have no overlap.
res.status(400).type('text').send('Only http and https targets are supported.');
return;
}
Expand All @@ -250,7 +262,7 @@
return;
}

if (parsedTarget.protocol === 'http:') {

Check failure on line 265 in src/server/proxy.ts

View workflow job for this annotation

GitHub Actions / Lint, Type-check & Build 

This comparison appears to be unintentional because the types '"https:"' and '"http:"' have no overlap.
parsedTarget.protocol = 'https:';
targetUrl = parsedTarget.href;
}
Expand Down
Loading