Order reinstall package phases - #23550
Conversation
|
Thanks for your pull request. This has been closed because it appears to be missing the pull request template, perhaps because this was written by an AI not a human. We require humans to read and fill in these templates. Please edit this pull request to fill in the current pull request template. This workflow will reopen this pull request automatically once the template is complete. Do not open a new pull request for this. |
There was a problem hiding this comment.
Pull request overview
This PR restructures brew reinstall to better sequence download/prefetch, reinstall execution, and post-run cleanup across formulae and casks, aiming to (1) prefetch downloads together, (2) keep going after individual failures, and (3) batch cleanup for successfully reinstalled packages.
Changes:
- Enqueue and prefetch formulae (including dependent formula installers) and casks into a shared
DownloadQueue, then proceed with reinstalls that successfully downloaded. - Track successfully reinstalled formulae/casks and perform a single
Cleanup.install_clean!at the end of the run. - Extend
Cask::Reinstall.reinstall_casksto optionally accept prebuilt installers and return the list of successfully reinstalled casks; update/add specs to validate ordering and cleanup behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Library/Homebrew/cmd/reinstall.rb | Reorders reinstall phases: shared prefetch, serial reinstall after failures, and end-of-run batch cleanup. |
| Library/Homebrew/cask/reinstall.rb | Adds support for passing cask installers and returning the successfully reinstalled casks. |
| Library/Homebrew/test/cmd/reinstall_spec.rb | Adds/updates command-level specs to validate phase ordering and cleanup timing. |
| Library/Homebrew/test/cask/reinstall_spec.rb | Updates cask reinstall specs for new prefetch messaging and installer behavior. |
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
adce3de to
9660d45
Compare
- prefetch formula and cask reinstall downloads together - continue serial reinstalls after individual failures - batch cleanup for successfully reinstalled packages
9660d45 to
03de9a4
Compare
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.6 GPT Sol xhigh with local review and testing.