Skip to content

Embed packaged NodeBook workspace in NodeRoom - #249

Merged
HomenShum merged 1 commit into
mainfrom
agent/nodebook-embed-noderoom
Aug 5, 2026
Merged

Embed packaged NodeBook workspace in NodeRoom#249
HomenShum merged 1 commit into
mainfrom
agent/nodebook-embed-noderoom

Conversation

@HomenShum

@HomenShum HomenShum commented Aug 5, 2026

Copy link
Copy Markdown
Owner

What changed

  • embeds NodeBook 0.1.4 contracts, core, model, and React packages as pinned tarballs
  • adds a room-scoped, read-only NodeBook workspace alongside the existing artifact modes
  • projects six portable visual artifact formats through the shared renderer
  • preserves existing selection, tab, trace, and export behavior
  • caches semantic projections and renders bounded, honest host errors

Why

NodeBook needs a clean consumer proof that NodeRoom can host the shared artifact model without copying NodeBook source or replacing NodeRoom lifecycle semantics.

Impact

Room participants can inspect supported NodeBook artifacts in the existing side surface. Foreign-room, malformed, and oversized payloads fail closed.

Validation

  • scenario suite: 6 tests, including all six formats, scope denial, malformed data, and a 500-artifact repeated-render benchmark
  • benchmark: 152.9 ms before vs 43.1 ms after across 1,000 unchanged renders (3.55x); projections 1,000 to 1
  • full CI, production build, packed consumer, design QA, and proof-loop gates passed
  • production dependency audit: 0 known vulnerabilities
  • exact-SHA Vercel preview: https://noderoom-r3b0imlc5-hshum2018-gmailcoms-projects.vercel.app
  • 1440x900 live DOM/pixel proof: NodeBook outline/editor/canvas render with no page overflow and no console errors or warnings

Residual limits

  • NodeBook package source is still part of the uncommitted NodeBook migration branch; this PR pins reproducible 0.1.4 package artifacts but does not canonicalize that producer branch.

@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
noderoom Ready Ready Preview Aug 5, 2026 11:16am

Request Review

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Scaffold Handoff — For Your Coding Agent

Your coding agent (Codex, Claude Code, etc.) should apply the accepted
scaffold proposals below. Do NOT touch any immutable files.

Immutability Check

Mode: advisory

✅ No immutable files were modified in this branch.

Changed Files

  • .gitignore
  • docs/eval/OFFICIAL_BENCHMARK_READINESS.md
  • docs/eval/OFFICIAL_BENCHMARK_TASK_COVERAGE.md
  • docs/eval/OPENROUTER_CONVEX_BENCHMARK.md
  • docs/eval/agent-improvement-loop.md
  • docs/eval/agent-improvement-loop.svg
  • docs/eval/agent-improvement-loop/20260805T111533Z.json
  • docs/eval/agent-improvement-loop/latest.json
  • docs/eval/agent-workspace-sandbox-smoke.json
  • docs/eval/algorithm-artifact-smoke.json
  • docs/eval/bankertoolbench-official-contract.json
  • docs/eval/docker-sandbox-probe.json
  • docs/eval/eval-runs.jsonl
  • docs/eval/halo-convex-context-telemetry.json
  • docs/eval/halo-self-improvement-smoke.json
  • docs/eval/halo-variant-selection.json
  • docs/eval/official-benchmark-readiness.json
  • docs/eval/official-benchmark-task-coverage.json
  • docs/eval/openrouter-convex-benchmark.json
  • docs/eval/professional-catalog-proofs.json
  • docs/eval/professional-proof-ledger.json
  • docs/eval/spreadsheetbench-chart-visual-probe.json
  • docs/eval/traces/credit/20260805T111543301Z-5c575610_dirty.aa81834b7e75ef9d/cascade-healthy.json
  • docs/eval/traces/credit/20260805T111543301Z-5c575610_dirty.aa81834b7e75ef9d/delta-incomplete.json
  • docs/eval/traces/credit/20260805T111543301Z-5c575610_dirty.aa81834b7e75ef9d/mapping-correct.json
  • docs/eval/traces/credit/20260805T111543301Z-5c575610_dirty.aa81834b7e75ef9d/mapping-misbind.json
  • docs/eval/traces/credit/20260805T111543301Z-5c575610_dirty.aa81834b7e75ef9d/summit-stressed.json
  • docs/eval/traces/ladder/20260805T111542818Z-5c575610_dirty.2a97dc0609780cb1/ladder_L1_read_scripted.json
  • docs/eval/traces/ladder/20260805T111542818Z-5c575610_dirty.2a97dc0609780cb1/ladder_L2_edit_scripted.json
  • docs/eval/traces/ladder/20260805T111542818Z-5c575610_dirty.2a97dc0609780cb1/ladder_L3_conflict_scripted.json
  • docs/eval/traces/ladder/20260805T111542818Z-5c575610_dirty.2a97dc0609780cb1/ladder_L4_blocked_scripted.json
  • docs/eval/traces/ladder/20260805T111542818Z-5c575610_dirty.2a97dc0609780cb1/ladder_L5_large_range_scripted.json
  • docs/eval/traces/ladder/20260805T111542818Z-5c575610_dirty.2a97dc0609780cb1/ladder_L6_long_horizon_scripted.json
  • docs/eval/traces/ladder/20260805T111542818Z-5c575610_dirty.2a97dc0609780cb1/ladder_L7_resume_scripted.json
  • package-lock.json
  • package.json
  • src/notebook/NodeBookArtifactElementSurface.tsx
  • src/notebook/NodeBookArtifactPanel.tsx
  • src/notebook/NodeBookWorkspaceSurface.tsx
  • src/notebook/visualArtifactEnvelope.ts
  • src/ui/panels/Artifact.tsx
  • tests/nodebookProjectionBenchmark.test.tsx
  • tests/nodebookWorkspaceProjection.test.tsx
  • vendor/nodebook/nodebook-contracts-0.1.4.tgz
  • vendor/nodebook/nodebook-core-0.1.4.tgz
  • vendor/nodebook/nodebook-model-0.1.4.tgz
  • vendor/nodebook/nodebook-react-0.1.4.tgz

Needs Adversarial Review — Do NOT Apply Yet

These proposals passed the reject check but have not been approved by
an adversarial reviewer. A human or frozen LLM judge must approve them first.

  • scaf-001 (AGENTS.md): Add explicit instruction for step spreadsheetbench-runner-fixture: Step spreadsheetbench-runner-fixture failed — scaffold may need explicit instruction or evidence assertion.
  • scaf-002 (AGENTS.md): Add explicit instruction for step convex-boundaries: Step convex-boundaries failed — scaffold may need explicit instruction or evidence assertion.

Safety Boundary

Agent may improve the scaffold.
Agent may NOT weaken the proof gate.

Immutable files (never modify):

  • scripts/proofloop.mjs
  • scripts/agent-improvement-loop.ts
  • tests/harnessChangeEval.test.ts
  • .github/workflows/
  • src/eval/evalTrustPolicy.ts
  • src/eval/architectureBudget.ts
  • evals/evalStore.ts

Scaffold files (safe to modify):

  • AGENTS.md
  • CLAUDE.md
  • proofloop/scenarios/*.yaml
  • proofloop/rubrics/*.yaml
  • proofloop/subagents/*.md
  • proofloop/adapters/*.js
  • .proofloop/memory.jsonl
  • src/nodeagent/models/prompts/systemPrompt.ts

@HomenShum
HomenShum force-pushed the agent/nodebook-embed-noderoom branch from 95912cd to 95653e5 Compare August 5, 2026 11:14
@HomenShum
HomenShum marked this pull request as ready for review August 5, 2026 11:47
@HomenShum
HomenShum merged commit 0bb92c4 into main Aug 5, 2026
13 checks passed
@HomenShum
HomenShum deleted the agent/nodebook-embed-noderoom branch August 5, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant