Fix: Replace incorrect apt install with dpkg -i for local deb package installation#7
Open
luisadha wants to merge 1 commit into
Open
Fix: Replace incorrect apt install with dpkg -i for local deb package installation#7luisadha wants to merge 1 commit into
luisadha wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR replaces the incorrect use of apt install -y for local .deb packages with the proper dpkg -i command. Problem using apt install -y directly on local paths fails on certain environments. I have tested this multiple times on my local machine (Termux on Android), and the current implementation does not work as intended for local Debian packages.
Solution:
Change the installation command to use dpkg -i instead.
Target command:
dpkg -i /path/location/opencode_1.17.7_aarch64.debI have successfully implemented and tested this approach in my own project using the following configuration:export FZF_DEFAULT_OPTS=(--bind="one:execute(tmpfile=\$(mktemp) && wget -O \"\$tmpfile\" {3} && dpkg -i \"\$tmpfile\" && rm -f \"\$tmpfile\" && exit)+abort" )References
Source Implementation:
luisadha/nene