Skip to content

Add autoComplete option for the AutoComplete component Textfield#29

Open
badoet wants to merge 4 commits into
HriBB:masterfrom
badoet:feature/autocomplete-on-autocomplete
Open

Add autoComplete option for the AutoComplete component Textfield#29
badoet wants to merge 4 commits into
HriBB:masterfrom
badoet:feature/autocomplete-on-autocomplete

Conversation

@badoet

@badoet badoet commented Apr 4, 2018

Copy link
Copy Markdown

so we can pass down autoComplete props down to the Textfield component in the Autocomplete component

the default autocomplete of the browser textfield sometimes make the UI looks abit off..

@HriBB

HriBB commented Apr 5, 2018

Copy link
Copy Markdown
Owner

Tests fail. Looks like you're not doing anything with autoComplete prop.

ERROR in ./src/AutoComplete/AutoComplete.js
/home/travis/build/HriBB/react-mdl-extra/src/AutoComplete/AutoComplete.js
  80:14  error  'autoComplete' is assigned a value but never used  no-unused-vars
✖ 1 problem (1 error, 0 warnings)

@badoet

badoet commented Apr 6, 2018

Copy link
Copy Markdown
Author

@HriBB seems like something wrong with the packaging? im not sure why though.
pretty sure my code is correct now

@HriBB

HriBB commented Apr 6, 2018

Copy link
Copy Markdown
Owner

@badoet yes looks like it. Tests are failing again. I guess there are a lot of old and deprecated dependencies.

I can look at it next week, but if you want, I can give you owner access to the repo, and you can fix it yourself ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants