Fix banner unicode crashes and add git repository checks to commands - #118
Merged
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Changes
banner.py: fixed unicode crashes on older Windows terminals, made all box borders consistently green, and added a friendly message when run outside a git repo instead of throwing an error.gitgo push,pull,state,undo, andresolve: added a check so running them outside a git repo prints a friendly error instead of crashing.tests: added new tests intest_banner.pyfor the non-git repo behavior and updated test mocks intest_resolve.py.Checklist
CHANGELOG.mdupdated under[Unreleased]README.mdupdated (if a command was added or changed)