fix: auth, signing, and CLI improvements - #120
Merged
Merged
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Changes
ssh_utils.py:gitgo pushno longer tries to convert HTTPS to SSH for non-GitHub hosts (Gitea, GitLab, private servers). It checks the remote hostname first. Onlygithub.comgets the SSH conversion. This was the main reason push failed silently on private servers with a different account.ssh_utils.py: addedis_agent_loaded(key_path)to check if a key is in the SSH agent. Also addedget_remote_host(url)to extract the hostname from any remote URL.ssh_utils.py:ensure_known_hostnow accepts any hostname, not justgithub.com. Oldensure_github_known_hostkept as an alias so nothing breaks.git_core.py:_get_signing_flagsnow uses the SSH signing key file from disk directly, and no longer crashes or skips signing based on the SSH agent state.account.py:sanitize_signing_confignow checks if the SSH signing key file exists on disk, disabling commit signing gracefully if it is missing to prevent failures.push.py: whengitgo pushis run with no arguments, both the default branch and the default message are now shown. Before, only one of them was printed.main.py: removed the letter aliases (-l,-s,-o,-d) fromgitgo state. They caused confusion for new users who ran-sexpecting something other than save.main.py: rewrote help text forpush,sync,link,jump,resolve,undo, andstatein plain language.state.py: removed alias resolution logic fromstate_operationto match the parser change.README.md: updatedgitgo pushsection to document the both-defaults behavior with an example output. Updatedgitgo state,sync,link,jump,resolve, andundosections to match new help text. Removed the aliases note from state docs.Checklist
CHANGELOG.mdupdated under[Unreleased]README.mdupdated (if a command was added or changed)