fix: stop spinner before re-raising Ctrl+C and guard GitHub-only feat… - #122
Merged
Merged
Conversation
…ures for non-GitHub hosts
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Changes
executor.py: wrapsubprocess.runin its owntry/except KeyboardInterruptso the yaspin spinner is stopped before the interrupt is re-raised. This was causing a ghost spinner to re-appear after Ctrl+C in any command.pull.py,jump.py,undo.py: removedloading_msgandok_textfromrun_commandcalls inside interrupt cleanup functions. Cleanup paths don't need a spinner.link.py: replaced hardcodedensure_github_known_host()withget_remote_host(url)→ensure_known_host(host). SSH check now targets the actual remote host, not alwaysgithub.com. Works for GitLab, Gitea, self-hosted, etc.init.py:_parse_template_slugnow checks if the URL points to a non-GitHub host and raises a clear error instead of letting the GitHub API call fail mid-download.repo.py: added an upfrontinfo()line at the start ofrepo_operationso users know this command is GitHub-specific before anything runs.Checklist
CHANGELOG.mdupdated under[Unreleased]README.mdupdated (if a command was added or changed)