Skip to content

refactor: migrate Docker integration to moby/moby/client#28

Open
yinonv wants to merge 1 commit into
mainfrom
refactor/migrate-to-moby-client
Open

refactor: migrate Docker integration to moby/moby/client#28
yinonv wants to merge 1 commit into
mainfrom
refactor/migrate-to-moby-client

Conversation

@yinonv
Copy link
Copy Markdown
Contributor

@yinonv yinonv commented Jun 2, 2026

Migrates envite's Docker integration off the legacy github.com/docker/docker client packages onto the new github.com/moby/moby/client (v2) API.

Changes

  • Swap imports from docker/docker/{api/types,client,errdefs,pkg/...} to moby/moby/{client,api/...} and containerd/errdefs.
  • Update call sites to the new options-struct signatures: ImageTag, ContainerCreate, ContainerStart/Stop/Remove, ImageRemove, ExecCreate/Attach/Inspect, and ContainerList.
  • Replace filters.NewArgs with client.Filters, jsonmessage.JSONMessage with jsonstream.Message, and types.Container with container.Summary.
  • Use container.StateRunning instead of the "running" string literal.
  • Update go.mod/go.sum accordingly.

Notes

  • Touches docker/{component,config,logs,network,runtime,waiter}.go and cmd/envite/docker.go.
  • No behavioral change intended; this is an API migration to the maintained moby client.

Made with Cursor

@yinonv yinonv force-pushed the refactor/migrate-to-moby-client branch from 74fbe07 to b2b6a54 Compare June 2, 2026 11:09
@yinonv yinonv requested a review from Copilot June 2, 2026 11:18

This comment was marked as outdated.

@yinonv yinonv force-pushed the refactor/migrate-to-moby-client branch 2 times, most recently from d0f3116 to 12256d9 Compare June 2, 2026 11:43
@yinonv yinonv requested a review from Copilot June 2, 2026 11:45
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.

Comment thread docker/config.go
Comment thread go.mod
Comment thread .github/workflows/go.yml
Comment thread docker/config.go
Replace the legacy github.com/docker/docker client packages with the new
github.com/moby/moby/client (v2) API across the docker component, config,
logs, network, runtime, and waiter, updating call sites to the new
options-struct based signatures. Bump related dependencies in go.mod/go.sum.

Co-authored-by: Cursor <cursoragent@cursor.com>
@yinonv yinonv force-pushed the refactor/migrate-to-moby-client branch from 12256d9 to b19699f Compare June 2, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants