Fix macOS hypa_read sed slicing and git worktree project-root detection - #91
Merged
Merged
Conversation
BSD sed rejects -- as end-of-options, so hypa_read offset/limit polluted stderr and failed nonzero on macOS. Drop -- on the sed branch and prefix leading-dash paths with ./ so sed does not parse them as options. Git worktrees (and submodules) use a .git file rather than a directory; treat either form as a project-root marker so hypa read resolves against the worktree instead of walking past it. Closes #89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two independent macOS bugs reported in #89:
hypa_readoffset/limit on BSD sed —buildReadCommand()no longer passes--tosed(BSD sed treats it as a filename). Relative paths starting with-get a./prefix so sed does not parse them as options.cat --is unchanged.GitProjectRootDetectornow treats a.gitfile (worktrees/submodules) as a root marker, not only a.gitdirectory.Bare-name spawn resolving non-executable cwd files is intentionally out of scope (follow-up).
Test plan
dotnet test tests/Hypa.UnitTests --filter FullyQualifiedName~GitProjectRootDetector(9 passed)cd packages/pi-hypa && npm test(78 passed)NO_BLOCKING_ISSUESCloses #89