Exclude AOT debug sidecars from release packages - #92
Merged
Conversation
StripSymbols leaves macOS .dSYM, Linux .dbg, and Windows .pdb next to the native binary. Copying the full publish tree shipped that bloat into GitHub archives, npm platform packages, and PyPI wheels. Drop the sidecars when packaging, with npm/wheel extract filters as defense in depth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PublishAot+StripSymbolswrites platform debug sidecars beside the native binary (macOS*.dSYM, Linux*.dbg, Windows*.pdb). Release packaging copied the entire publish tree into archives, so those files landed in:@hypabolic/hypa-*npm platform packages (e.g.bin/hypa.dSYM/...)That inflated
@hypabolic/hypa-darwin-x64enough that cnpm/npmmirror rejected sync (see #90: ~188 MB vs 80 MB allow). None of the sidecars are needed at runtime — the executable is already stripped.Changes
*.dSYMdirectories and*.pdb/*.dbgfiles before archiving.StripSymbolsinHypa.Cli.csprojpointing at the packaging rule.Historic published versions (e.g. 0.1.5) cannot be rewritten; this applies from the next release onward.
Test plan
*.dSYMbin/hypa(and grammar dylib/so) still shipCloses #90