Add Kerberos byte[] support to AS400JDBCDriver#332
Conversation
Signed-off-by: Yeluri Chaitanya <Yeluri.Chaitanya1@ibm.com>
e5770d7 to
c3f7738
Compare
|
Hi @jeber-ibm , Can you please verify the changes. I've changed "setKerbTicket(byte[])" method in "AS400" public so it can be used by external components. |
jeber-ibm
left a comment
There was a problem hiding this comment.
Please add additional methods as indicated in the review.
b58c24d to
ddc26c7
Compare
Align RowSet Kerberos setter with property change pattern Add kerberosTicket_ field to RowSet Signed-off-by: Yeluri Chaitanya <Yeluri.Chaitanya1@ibm.com>
ddc26c7 to
76d694f
Compare
There was a problem hiding this comment.
The AS400 object should already have had the kerberos ticket set on the AS400 object. But if you think these methods are needed, then they can be kept.
I would like to see the following methods added to the AS400JDBCDriver class.
public java.sql.Connection connect (String url, byte[] kerberosTicket)
public java.sql.Connection connect (String url, Properties info, byte[] kerberosTicket)
You will also need methods to set the ticket on the AS400JDBCDataSource and AS400JDBCManagedDataSource classes.
There was a problem hiding this comment.
You need to add some Javadoc for the setKerbTicket method.
There was a problem hiding this comment.
You need to add some Javadoc for this new method.
There was a problem hiding this comment.
Javadoc needed for the new public method.
There was a problem hiding this comment.
You need to make a protected copy of the kerberosTicket_ (look how the password is protected). You also need to use the kerboseTicket_ to make a connection (instead of using a password to make a connection).
Signed-off-by: Yeluri Chaitanya <Yeluri.Chaitanya1@ibm.com>
Signed-off-by: Yeluri Chaitanya <Yeluri.Chaitanya1@ibm.com>
…et_ to make a connection Signed-off-by: Yeluri Chaitanya <Yeluri.Chaitanya1@ibm.com>
2854349 to
30267a7
Compare
|
Hi @jeber-ibm , Can you please check on my new changes. |
#330 Got merged and this PR adds Kerberos byte[] support to AS400JDBCDriver