Skip to content

Fix Nanodac PV DB generation#960

Open
Tom-Willemsen wants to merge 3 commits intomasterfrom
nanodac
Open

Fix Nanodac PV DB generation#960
Tom-Willemsen wants to merge 3 commits intomasterfrom
nanodac

Conversation

@Tom-Willemsen
Copy link
Copy Markdown
Member

@Tom-Willemsen Tom-Willemsen commented May 1, 2026

Description of work

DB loading for the Nanodac IOC was totally broken. This fixes it.

To review: check that if you start the NANODAC IOC, it loads DB records correctly (note: you'll need to pass in some IP address otherwise it crashes - but this can just be e.g. 127.0.0.1).

@FreddieAkeroyd
Copy link
Copy Markdown
Member

FreddieAkeroyd commented May 1, 2026

The only instance i am aware of was on control-svcs that looked at a zoom nanodac, this doesn't seem to use this db and instead loads $(NANODAC)/db/nanodac.db directly passing S, ND, NI so probably why this hasn't been noticed.

@FreddieAkeroyd
Copy link
Copy Markdown
Member

FreddieAkeroyd commented May 1, 2026

I don't know what ND and NI are, but is it more useful not to explicitly hard code them as 1 here and instead let them be macros passed via dbLoadRecords ? So basically delete this substitutions file and adjust st.cmd?

@pull-request-size pull-request-size Bot added size/S and removed size/XS labels May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Flash Review

Development

Successfully merging this pull request may close these issues.

2 participants