Fix: Network include filter being broken and never being applied properly#479
Open
LordHepipud wants to merge 1 commit into
Open
Fix: Network include filter being broken and never being applied properly#479LordHepipud wants to merge 1 commit into
LordHepipud wants to merge 1 commit into
Conversation
LordHepipud
force-pushed
the
fix/network_include_filter_broken
branch
from
89c7114 to
5d3184b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The include network interface filter for
Invoke-IcingaCheckNetworkInterfacewas never able to include any filtered object, as it checked for the device id, device name and interface name at the same time.For easier usage, the filter will now only work for the interface name for both, include and exclude filter for the interface.