fix(overlay): Prevent scrolling with wheel and touchpad when BlockScrollStrategy is set on Safari#17274
Open
mddragnev wants to merge 1 commit into
Open
fix(overlay): Prevent scrolling with wheel and touchpad when BlockScrollStrategy is set on Safari#17274mddragnev wants to merge 1 commit into
mddragnev wants to merge 1 commit into
Conversation
mddragnev
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Safari-specific behavior where BlockScrollStrategy fails to prevent scrolling early enough by intercepting wheel/touch scrolling input before the browser scrolls.
Changes:
- Add non-passive
wheelandtouchmovelisteners that callpreventDefault()to block scroll before it occurs (Safari fix for #17217). - Keep the existing capture
scrolllistener as a fallback for keyboard-driven scrolling. - Add cleanup for the new listeners on
detach().
| this._sourceElement.scrollLeft = this._initialScrollLeft; | ||
| }; | ||
|
|
||
| private preventDefault = (ev: Event) => { |
Comment on lines
+39
to
+43
| // This also fixes Safari bug #17217 where the scroll event fires after the compositor has already | ||
| // scrolled, making scroll-position reset ineffective for wheel/touch input. | ||
| this._document.addEventListener('wheel', this.preventDefault, { passive: false }); | ||
| this._document.addEventListener('touchmove', this.preventDefault, { passive: false }); | ||
| // Handles keyboard-driven scrolling (arrow keys, spacebar, Page Up/Down) as a fallback, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…uchmove
Closes #17217
Description
Prevent scroll from mouse/trackpad/touch before it occurs.
This also fixes the Safari case where the scroll event fires after the compositor has already scrolled, making scroll-position reset ineffective for wheel/touch input.
Type of Change (check all that apply):
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)