fix(vhelper): ensure horizontal helper has defined height for scrollbar#17279
Open
mddragnev wants to merge 1 commit into
Open
fix(vhelper): ensure horizontal helper has defined height for scrollbar#17279mddragnev wants to merge 1 commit into
mddragnev wants to merge 1 commit into
Conversation
mddragnev
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Safari-specific issue where the horizontal scrollbar in igx-for-of was not rendered correctly because Safari did not derive a height from the ::-webkit-scrollbar pseudo-element. The fix gives the horizontal helper an explicit height using the existing --vhelper-scrollbar-size CSS custom property (already used to set the vertical helper's width on line 15), ensuring consistent scrollbar sizing across browsers.
Changes:
- Add an explicit
height: var(--vhelper-scrollbar-size)to the%vhelper--horizontalplaceholder so Safari renders the horizontal scrollbar at the correct size.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17216
Description
For some reason Safari does not calculate the correct height from pseudo classes ::webkit-scrollbar. Might be because it is a variable.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)