docs: sync Immediate.Jobs through 1530bc1 - #19
Open
dukesteen wants to merge 5 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (16)
📝 WalkthroughWalkthroughThe documentation updates describe renamed batch APIs, generated recurring-job dispatch, fluent registration, storage topology and capabilities, health checks, diagnostics, fair queues, and provider conformance testing. ChangesImmediate Jobs documentation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dukesteen
changed the title
dukesteen
changed the title
dukesteen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1530bc1(rangeaebc7f3..1530bc1, 16 commits).IImmediateJobsBuilder,ConfigureWorkers, explicit storage selection,DisableWorkers, and configuration binding.JobStorageConformanceSuite.AllCasesByNameand correct a tagged-host example that could omit a job handler.Source audit
Every commit in the range was reviewed. The first 15 commits were covered by earlier commits in this PR. They include namespace changes, the unused-queue diagnostic, named recurring-job triggers, repeat-safe registration, storage tests, the first builder API,
JobMonitor, dashboard and Redis options, and dependency updates.The new commit,
1530bc1, changes the public configuration API:AddXxxJobsmethods now returnIImmediateJobsBuilder.ConfigureWorkers. Storage must be selected withConfigureStorage.DisableWorkerssupports applications that enqueue or display jobs while another process runs them.ConfigureDashboard.DataConnectiontype. Redis now resolves a registeredIConnectionMultiplexerand usesConfigureRedis.AllCasesByName.Internal test organization and dependency-only changes do not need separate application guidance.
Validation
pnpm checkpnpm lintpnpm builddotnet build tests/Immediate.Jobs.StorageTests/Immediate.Jobs.StorageTests.csproj -v minimalon Immediate.Jobs1530bc1dotnet build samples/Basic/Basic.csproj -v minimalon Immediate.Jobs1530bc1git diff --checkAll checks passed. The docs build reported its existing Vite chunk-size warning. The dashboard dependency audit reported 25 high-severity findings.