Skip to content

Clarify NodaTime serializer configuration - #135

Open
dukesteen wants to merge 1 commit into
docs/package-specific-readmesfrom
docs/nodatime-serializer-options
Open

Clarify NodaTime serializer configuration#135
dukesteen wants to merge 1 commit into
docs/package-specific-readmesfrom
docs/nodatime-serializer-options

Conversation

@dukesteen

Copy link
Copy Markdown
Contributor

Summary

  • document explicit JsonSerializerOptions and NodaTimeJobSerializer registration as the primary customization path
  • explain that Immediate.Jobs owns a dedicated durable JSON contract rather than using ASP.NET Core JSON options
  • clarify registration order so the custom IJobSerializer is preserved by Jobs registration
  • keep AddImmediateJobsNodaTime() as an optional defaults-only convenience
  • warn that all workers must use compatible serializer settings and time-zone IDs

Stack

This PR is stacked on #134 because the package-specific NodaTime README is introduced there. After #134 merges, this PR can be retargeted to main.

Validation

  • dotnet pack src/Immediate.Jobs.NodaTime/Immediate.Jobs.NodaTime.csproj -c Release -v minimal
  • verified the generated package contains an exact copy of the updated README

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8db55dd6-6bdf-4e25-b46f-aff7a2019168

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 32188301679

Warning

No base build found for commit bf10a15 on docs/package-specific-readmes.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 87.613%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 12118
Covered Lines: 10617
Line Coverage: 87.61%
Coverage Strength: 2.58 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants