skills: sync Immediate.Jobs through ee5f51d - #2
Open
dukesteen wants to merge 1 commit into
Open
Conversation
📝 WalkthroughWalkthroughThe PR updates Immediate.Jobs preview documentation across registration, storage, scheduling, operations, and testing. It adds the ChangesImmediate.Jobs guidance
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/README.md`:
- Line 51: Update the test-storage-provider row in the Markdown table so “Queue
| Recurring” does not create an extra column; escape the pipe or represent the
two terms with separate code spans while preserving the existing cell content.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 719e3f5d-fb54-4129-840e-e7ae6645cfdd
📒 Files selected for processing (21)
plans/skills.mdplugins/immediate-jobs/.codex-plugin/plugin.jsonplugins/immediate-jobs/skills/build-workflow/SKILL.mdplugins/immediate-jobs/skills/build-workflow/references/workflow-graphs.mdplugins/immediate-jobs/skills/configure-storage/SKILL.mdplugins/immediate-jobs/skills/configure-storage/references/storage-matrix.mdplugins/immediate-jobs/skills/create-job/SKILL.mdplugins/immediate-jobs/skills/create-job/references/job-contract.mdplugins/immediate-jobs/skills/create-recurring-job/SKILL.mdplugins/immediate-jobs/skills/create-recurring-job/references/recurring-patterns.mdplugins/immediate-jobs/skills/operate-jobs/SKILL.mdplugins/immediate-jobs/skills/operate-jobs/references/operations-patterns.mdplugins/immediate-jobs/skills/schedule-job/SKILL.mdplugins/immediate-jobs/skills/schedule-job/references/scheduling-patterns.mdplugins/immediate-jobs/skills/test-job/SKILL.mdplugins/immediate-jobs/skills/test-job/references/testing-patterns.mdplugins/immediate-jobs/skills/test-storage-provider/SKILL.mdplugins/immediate-jobs/skills/test-storage-provider/agents/openai.yamlplugins/immediate-jobs/skills/test-storage-provider/references/conformance-suite.mdtests/README.mdtests/activation-prompts.json
|
|
||
| | Skill | Scenario | Result | Guidance refined from the test | | ||
| | --- | --- | --- | --- | | ||
| | `$immediate-jobs:test-storage-provider` | xUnit catalog for a custom Redis provider with queue and recurring support | Correctly selected `Queue | Recurring` and produced one test row per case | Name the fake-time namespace/package and keep connection, data identifier, service provider, and cleanup in one fixture. | |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Escape the pipe in the Markdown table cell.
The Queue | Recurring text is parsed as a fifth column. markdownlint reports five cells for this row, so the guidance column is malformed. Use separate code spans or escape the pipe.
Proposed fix
- | `$immediate-jobs:test-storage-provider` | xUnit catalog for a custom Redis provider with queue and recurring support | Correctly selected `Queue | Recurring` and produced one test row per case | Name the fake-time namespace/package and keep connection, data identifier, service provider, and cleanup in one fixture. |
+ | `$immediate-jobs:test-storage-provider` | xUnit catalog for a custom Redis provider with queue and recurring support | Correctly selected the `Queue` and `Recurring` capabilities and produced one test row per case | Name the fake-time namespace/package and keep connection, data identifier, service provider, and cleanup in one fixture. |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| | `$immediate-jobs:test-storage-provider` | xUnit catalog for a custom Redis provider with queue and recurring support | Correctly selected `Queue | Recurring` and produced one test row per case | Name the fake-time namespace/package and keep connection, data identifier, service provider, and cleanup in one fixture. | | |
| | `$immediate-jobs:test-storage-provider` | xUnit catalog for a custom Redis provider with queue and recurring support | Correctly selected the `Queue` and `Recurring` capabilities and produced one test row per case | Name the fake-time namespace/package and keep connection, data identifier, service provider, and cleanup in one fixture. | |
🧰 Tools
🪛 markdownlint-cli2 (0.23.2)
[warning] 51-51: Table column count
Expected: 4; Actual: 5; Too many cells, extra data will be missing
(MD056, table-column-count)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@tests/README.md` at line 51, Update the test-storage-provider row in the
Markdown table so “Queue | Recurring” does not create an extra column; escape
the pipe or represent the two terms with separate code spans while preserving
the existing cell content.
Source: Linters/SAST tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
be75408..ee5f51d(20 commits).$immediate-jobs:test-storage-providerfor the public, framework-neutral storage behavior catalog.0.1.0-preview.2; it remainsNOT_AVAILABLE, and all eight preview skills keep implicit invocation disabled.Forward-test findings
Fresh-context tests covered custom Redis conformance tests, distributed EF Core configuration, and stable-name recurring dispatch. They refined fixture cleanup, fake-time imports, tag behavior, readiness mapping, and the temporary
ee5f51dhealth-check options bridge.Validation
python3 scripts/validate.pyee5f51dgit diff --checkSummary by CodeRabbit
New Features
test-storage-providerskill for validating custom storage implementations with conformance tests.0.1.0-preview.2.Documentation