Feat: Add navigation-starting interception and handlers - #386
Merged
Conversation
Introduce pre-navigation interception across managed and native layers. Adds CppNavigationStartingDelegate and NavigationStartingCallback, a NavigationStartingHandler in InfiniFrameInitParams, marshalling support, and platform integrations (Windows WebView2, macOS WKWebView, Linux WebKit) to allow callbacks to cancel navigations. Adds NavigationStartingEventArgs and NavigationStartingResult, event store support, RegisterNavigationStartingHandler extension, docs describing usage/platform notes, and unit tests validating handler invocation and cancellation behavior.
2 tasks
Wrap navigation URL C-strings with AutoString before calling the navigation callback on Linux and macOS to ensure proper ownership/lifetime. Changes applied in WindowSignals.Gtk.cpp (on_webview_decide_policy) and NavigationDelegate.mm (navigation handler) — behavior unchanged, prevents potential dangling pointer/ownership issues when callbacks store or use the passed string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #294