Update normalization parameters and add estimator params validation#210
Open
avolkov-intel wants to merge 6 commits intoIntelPython:mainfrom
Open
Update normalization parameters and add estimator params validation#210avolkov-intel wants to merge 6 commits intoIntelPython:mainfrom
avolkov-intel wants to merge 6 commits intoIntelPython:mainfrom
Conversation
ethanglaser
reviewed
May 6, 2026
| "data": { | ||
| "dataset": "hepmass", | ||
| "split_kwargs": { "train_size": 0.1, "test_size": null } | ||
| "split_kwargs": { "train_size": 0.1, "test_size": null }, |
Contributor
There was a problem hiding this comment.
Seems like this is the only case where benchmark behavior changes - is it intended?
ethanglaser
reviewed
May 6, 2026
Comment on lines
+7
to
+8
| "dataset" : "cifar", | ||
| "split_kwargs": { "ignore" : true }, |
Contributor
There was a problem hiding this comment.
Suggested change
| "dataset" : "cifar", | |
| "split_kwargs": { "ignore" : true }, | |
| "dataset": "cifar", | |
| "split_kwargs": { "ignore": true }, |
| "dataset": "mnist", | ||
| "split_kwargs": { "train_size": 20000, "test_size": null }, | ||
| "preprocessing_kwargs": { "normalize": false } | ||
| "preprocessing_kwargs": {"normalize" : null} |
Contributor
There was a problem hiding this comment.
Suggested change
| "preprocessing_kwargs": {"normalize" : null} | |
| "preprocessing_kwargs": { "normalize": null } |
Minor adjustment but looks like spaces have been added before colons in a few places throughout the configs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Estimator parameters validation can be useful in case you want to override some parameter like n_jobs using -p algorithm:estimator_params:n_jobs=64 for the benchmarks. Currently it would fail since some estimators don't support n_jobs and you would need to run the benchmarks separately. In this approach this parameter will be simply ignored by estimators that don't support it and warning will be shown.
Checklist:
Completeness and readability
Testing