Support RGB888 raw images and validate raw file size#25
Open
Inter-Raptor wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
.rawassets (e.g. boot/home backgrounds) were displayed garbled becausedisplayDrawRAWassumed 2 bytes/pixelRGB565format and did not validate file contents against expected size.RGB888raw images so correctly-exported assets render properly.Description
displayDrawRAWto detect whether the file matches the expectedRGB565(2 bytes/pixel) orRGB888(3 bytes/pixel) bytecount for the givenwidth/height.RGB565andRGB888, convertingRGB888pixels to 16-bit withlcd.color565(r,g,b), and adjusted row skipping to use the bytes-per-pixel value.Testing
rgto confirm all callers ofdisplayDrawRAW(launcher_ui.cpp) and inspected the modified function withnl/sedto verify the changes.boot.raw/home.bg.rawassets.Codex Task