evaluateTransaction: keep Babbage-format transactions evaluable#5
Merged
Conversation
…anoSolutions#464) Clients still build Babbage-format txs with no Conway-only fields, and submitTransaction already upgrades them via upgradeGenTx. evaluateTransaction's Babbage->Conway arm was dropped following @KtorZ's guidance that only `conwayToDijkstra` was needed [1]. v6.14.0.1 now rejects Babbage txs with `unsupportedEra`, regressing a flow that worked on v6.14.0 (CardanoSolutions#464). Restore it rather than deprecating Babbage: - newExecutionUnitsEvaluator: accept all (utxo, tx) era combos from Babbage up, upgrading both sides to a common era. - translateToNetworkEra: add Babbage->Conway alongside Conway->Dijkstra, so a Babbage bundle reaches the network era instead of the "impossible" error. [1]: CardanoSolutions#461 (comment) https://github.com/CardanoSolutions/ogmios/pull/461/changes#discussion_r3231841439
johnalotoski
force-pushed
the
jordan/fix-464
branch
from
df0ba63 to
bfe54c0
Compare
johnalotoski
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore evaluation of Babbage-format transactions in
evaluateTransaction, which regressed inv6.14.0.1.Addresses IntersectMBO/ogmios#6.
Context
Clients still build Babbage-format transactions that carry no Conway-only fields.
The
Babbage -> Conwaytranslation arm was dropped following review guidance on CardanoSolutions#461 that onlyconwayToDijkstrawas needed (comment). This idea was propagated to other parts of the code that resulted in the failures reported.Changes
newExecutionUnitsEvaluator— accept every(utxo, tx)era combination from Babbage up, upgrading both sides to a common era instead of rejecting Babbage inputs.translateToNetworkEra— add theBabbage -> Conwayarm alongside the existingConway -> Dijkstra, so a Babbage bundle (e.g. a Babbage tx with noadditionalUtxo) is lifted to the network era instead of falling through to theimpossibleerror.Testing
A minimal Babbage tx (1 input, 2 ada-only outputs, fee) — the one reported in the issue — was evaluated against a preview node:
v6.14.0.1):unsupportedErarejection (and, with only the evaluator change, animpossible: arguments are not translatable to network eracrash).{"result":[]}— success (no scripts to budget), matchingv6.14.0.