chore(miner): migrate batch 4.6 foundational lib modules to TypeScript (#7314)#7327
chore(miner): migrate batch 4.6 foundational lib modules to TypeScript (#7314)#7327andriypolanski wants to merge 3 commits into
Conversation
JSONbored#7314) Convert eight foundational loopover-miner lib modules from plain .js + hand-maintained .d.ts to real TypeScript under the existing in-place tsc emit pipeline, with zero behavior change. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7327 +/- ##
==========================================
- Coverage 91.03% 91.01% -0.02%
==========================================
Files 714 714
Lines 72102 72124 +22
Branches 19163 19323 +160
==========================================
+ Hits 65635 65646 +11
Misses 5427 5427
- Partials 1040 1051 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Stop rebasing - let CI run, there's no need to rebase. All it does is slow down the pipeline, these are single-shot reviews. |
|
Caution 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-19 17:48:17 UTC
Review summary Nits — 6 non-blocking
CI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate-tests-merge, validate, validate-tests (6), validate-tests (2), validate-tests (4), validate-tests (5), validate-tests (1), validate-tests (3))). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
policy-verdict-cache,submission-freshness-check,github-token-resolution,worktree-allocator,contribution-profile,http-retry,repo-clone, andchat-action-registryfrom plain.js+ hand-maintained.d.tsto real.tsunder the existing in-placetscemit pipeline from chore(miner): add a real tsc build pipeline for loopover-miner (#7290) #7299..js/.d.tsviatscso published layout and consumer import paths stay unchanged; zero behavior change.Closes #7314
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
src/**— this PR only touchespackages/loopover-miner/lib/**. Rannpm run build:miner,npm run test:miner-pack,git diff --check, andnpm run actionlint. Fulltest:ci/ UI / workers / coverage chain was exercised on the sibling batch 4.7 PR (chore(miner): migrate batch 4.7 foundational lib modules to TypeScript (#7315) #7319) against the same pipeline; this migration is the same class of change.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — no visible UI/frontend/docs change.
Notes
lib/foo.ts→lib/foo.js+ regenerated.d.ts).tsconfig.jsonchanges; the existinglib/**/*.tsinclude glob picks up the new sources.