chore(miner): migrate batch 3.3 CLI command modules to TypeScript (#7307)

[andriypolanski]

Summary

• Batch 3.3 of the chore(miner): migrate packages/loopover-miner from plain .js + hand-maintained .d.ts to real TypeScript #7290 migration (Phase 3): converts lib/portfolio-queue-cli.js, lib/loop-cli.js, lib/governor-metrics-cli.js, lib/discover-cli.js, lib/governor-pause-cli.js, and lib/attempt-cli.js (plus their hand-maintained .d.ts siblings) from plain .js to real .ts.
• Uses the same in-place-emit build pipeline Phase 1 (chore(miner): add a real tsc build pipeline for loopover-miner (#7290) #7299) already wired up (lib/foo.ts compiles to lib/foo.js at the same path), so every consumer's import path stays identical.
• No behavior change. Pre-existing type/optional-prop drifts vs not-yet-converted siblings are preserved with casts (same approach as batch 3.1 chore(miner): migrate CLI command packages/loopover-miner/lib modules to TypeScript (#7305) #7331), not "fixed."

Closes #7307

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

• git diff --check
• npm run actionlint
• npm run typecheck
• npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi:check
• npm run ui:lint
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

• No behavior change; existing miner unit tests for these six modules continue to pass unmodified (260 tests across the related suites). Codecov patch applies only to src/** — this PR only touches packages/loopover-miner/lib/**. Also ran: npm run build --workspace @loopover/miner, npm run test:miner-pack, and npx tsc -p packages/loopover-miner/tsconfig.json. Pre-existing adm-zip advisories via github-actionlint remain (no fix available; not introduced here). Full test:ci UI/workers/mcp chain not re-run for this packages-only migration (mirrors batch 3.1 / 4.7 notes).

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
• API/OpenAPI/MCP behavior is updated and tested where needed.
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — no visible UI/frontend/docs change.

Notes

• Follows the Phase 1 in-place-emit pattern from chore(miner): add a real tsc build pipeline for loopover-miner (#7290) #7299 (lib/foo.ts → lib/foo.js + regenerated .d.ts).
• No tsconfig.json changes; the existing lib/**/*.ts include glob picks up the new sources.

[codecov]

Codecov Report

❌ Patch coverage is 92.90264% with 78 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.90%. Comparing base (f158305) to head (63b7a86).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/loopover-miner/lib/loop-cli.ts	86.66%	3 Missing and 29 partials ⚠️
packages/loopover-miner/lib/attempt-cli.ts	91.26%	4 Missing and 16 partials ⚠️
packages/loopover-miner/lib/portfolio-queue-cli.ts	94.11%	3 Missing and 14 partials ⚠️
packages/loopover-miner/lib/discover-cli.ts	95.40%	0 Missing and 9 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7337      +/-   ##
==========================================
+ Coverage   91.03%   91.90%   +0.86%     
==========================================
  Files         714      631      -83     
  Lines       72118    51517   -20601     
  Branches    19232    15942    -3290     
==========================================
- Hits        65651    47345   -18306     
+ Misses       5427     3242    -2185     
+ Partials     1040      930     -110     

Flag	Coverage Δ
rees	?
shard-1	41.30% <3.73%> (-0.43%)	⬇️
shard-2	35.67% <39.85%> (-0.06%)	⬇️
shard-3	31.58% <17.01%> (-0.04%)	⬇️
shard-4	32.72% <6.09%> (+0.13%)	⬆️
shard-5	30.05% <0.00%> (-0.53%)	⬇️
shard-6	43.70% <38.85%> (+0.15%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ackages/loopover-miner/lib/governor-metrics-cli.ts	100.00% <100.00%> (ø)
packages/loopover-miner/lib/governor-pause-cli.ts	100.00% <100.00%> (ø)
packages/loopover-miner/lib/discover-cli.ts	95.40% <95.40%> (ø)
packages/loopover-miner/lib/portfolio-queue-cli.ts	94.11% <94.11%> (ø)
packages/loopover-miner/lib/attempt-cli.ts	91.26% <91.26%> (ø)
packages/loopover-miner/lib/loop-cli.ts	86.66% <86.66%> (ø)

... and 89 files with indirect coverage changes

[loopover-orb]

Caution

🛑 LoopOver review result - reject/close recommended

_{Review updated: 2026-07-19 18:38:01 UTC}

18 files · 1 AI reviewer · 1 blocker · CI failing · blocked

🛑 Suggested Action - Reject/Close

Review summary
This is described as a mechanical JS-to-TS migration (batch 3.3) of six CLI modules, but the diff shows both .ts and .js versions of the same files with substantive content in each (e.g. attempt-cli.js at 698 lines and attempt-cli.ts at 866 lines, both full implementations) — that is inconsistent with an in-place-emit build pipeline where .ts compiles to .js at the same path, since compiled output should not be committed alongside source. Codecov/patch and the validate/validate-tests-merge checks are failing (92.90% vs 99% target), and this PR ships zero test changes across 18 changed files, which contradicts the 'no behavior change, just retyping' framing enough to warrant scrutiny of whether the .js files are stale generated artifacts checked into git or a real behavior fork between the two.

Blockers

• Both lib/attempt-cli.js and lib/attempt-cli.ts (and the other four module pairs) are committed as full, independently-authored-looking source, not a compiled artifact; if the build pipeline is supposed to emit .js from .ts at build time, committing hand-written or drifted .js siblings risks a stale/divergent runtime path being loaded instead of the new TS source — confirm the .js files are build output (e.g. via a .gitignore rule and CI compile step) and not manually maintained duplicates, or this PR ships two live implementations of the same CLI.
• codecov/patch is failing at 92.90% vs the required 99% threshold, which per this repo's own coverage gate blocks merge until the uncovered branches (e.g. the blocked_max_concurrent_claims/kill-switch-transition-record-failure paths in attempt-cli.ts, discovery-plane opt-in branches) get real tests.

Nits — 6 non-blocking

• This 866-line attempt-cli.ts (and the similarly oversized loop-cli.ts, discover-cli.ts, portfolio-queue-cli.ts) each exceed the repo's ~400-line file-size convention; consider whether the migration is a natural point to split runAttempt's many blocked-outcome branches into smaller helpers.
• loop-cli.ts:457 introduces an explicit `any` (`let lastResult: any = null`) with a comment explaining CFA collapse, but a narrower typed union or a type assertion at the read sites would avoid the blanket any.
• Numerous magic exit codes (3, 4, 5, 6, 7, 8, 9, 11) are scattered through attempt-cli.ts's return statements; a named exit-code enum/const map would make the `bin/loopover-miner.js` contract self-documenting and less error-prone to extend.
• Several new functions in attempt-cli.ts and discover-cli.ts hit control-flow depth 5 against the repo's depth-4 convention (e.g. attempt-cli.ts:191, discover-cli.ts:229) — worth an early-return refactor pass while the code is already being touched for the port.
• No test files were added or changed for any of the 18 files in this migration; even for a 'no behavior change' port, the existing .js test suite's coverage should be confirmed to still exercise the new .ts output 1:1.
• Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Why this is blocked

• Both lib/attempt-cli.js and lib/attempt-cli.ts (and the other four module pairs) are committed as full, independently-authored-looking source, not a compiled artifact; if the build pipeline is supposed to emit .js from .ts at build time, committing hand-written or drifted .js siblings risks a stale/divergent runtime path being loaded instead of the new TS source — confirm the .js files are build output (e.g. via a .gitignore rule and CI compile step) and not manually maintained duplicates, or this PR ships two live implementations of the same CLI.

📋 Copy for AI agents — paste into your coding agent

Fix the following blocker(s) from this PR review:

1. Both lib/attempt-cli.js and lib/attempt-cli.ts \(and the other four module pairs\) are committed as full, independently-authored-looking source, not a compiled artifact; if the build pipeline is supposed to emit .js from .ts at build time, committing hand-written or drifted .js siblings risks a stale/divergent runtime path being loaded instead of the new TS source — confirm the .js files are build output \(e.g. via a .gitignore rule and CI compile step\) and not manually maintained duplicates, or this PR ships two live implementations of the same CLI.

CI checks failing

• validate
• codecov/patch — 92.90% of diff hit (target 99.00%)
• validate-tests-merge

Decision drivers

• ❌ Code review — 1 blocker (1 reviewer)
• ❌ Gate result — Blocking (Repo-configured hard blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#7307
Related work	⚠️ 3 scoped overlaps	Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope	❌ 8/20	High review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 166 registered-repo PR(s), 111 merged, 22 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	andriypolanski; Gittensor profile; 166 PR(s), 22 issue(s).
Improvement	ℹ️ None detected	risk: low · value: none · LLM: moderate

Linked issue satisfaction

Addressed
The PR converts all six listed files to .ts (attempt-cli.ts and loop-cli.ts shown in full in the diff, with the description confirming the remaining four), matches the in-place-emit pattern from Phase 1, and states no behavior change with typecheck passing.

Review context

• Author: andriypolanski
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: not available
• Official Gittensor activity: 166 PR(s), 22 issue(s).
• Related work: Titles/paths share 6 meaningful terms. (issue #7300)
• Related work: Titles/paths share 6 meaningful terms. (issue #7302)
• Related work: Titles/paths share 6 meaningful terms. (issue #7301)
• Additional title-only matches omitted; title-only overlap does not block.

Contributor next steps

• Start here: Review top overlaps.
• Then work through the remaining 2 steps in the Signals table above.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, codecov/patch, validate-tests-merge); AI reviewers agree on a likely critical defect: Both lib/attempt-cli.js and lib/attempt-cli.ts (and the other four module pairs) are committed as full, independently-authored-looking source, not a compiled artifact; if the build pipeline is supposed to emit .js from .ts at build time, committing hand-written or drifted .js siblings risks a stale/divergent runtime path being loaded instead of the new TS source — confirm the .js files are build output (e.g. via a .gitignore rule and CI compile step) and not manually maintained duplicates, or this PR ships two live implementations of the same CLI.). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.