Skip to content

fix(miner-ui): give ChatComposer's textarea an accessible name#7465

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
jaytbarimbao-collab:ui-chat-aria-7440
Jul 20, 2026
Merged

fix(miner-ui): give ChatComposer's textarea an accessible name#7465
JSONbored merged 1 commit into
JSONbored:mainfrom
jaytbarimbao-collab:ui-chat-aria-7440

Conversation

@jaytbarimbao-collab

Copy link
Copy Markdown
Contributor

Summary

ChatComposer's <Textarea> (apps/loopover-miner-ui/src/components/chat-composer.tsx) had no aria-label/aria-labelledby/wrapping label. The ui-kit Textarea is a deliberately bare native <textarea>, so the caller must supply a name; placeholder isn't a substitute (WCAG 2.1 SC 3.3.2 / 4.1.2 — it disappears on input and its exposure to assistive tech as an accessible name is inconsistent).

Fix

Add a stable aria-label="Chat message" to the Textarea — hardcoded and independent of the placeholder prop (which callers can override), matching how the other bare/icon-only controls in this codebase (theme-toggle, the copy button, back-to-top, …) are labelled.

Verification

chat-composer.test.tsx's setup() now queries getByRole("textbox", { name: /chat message/i }), so the test asserts the accessible name exists and pins the fix. All chat-composer and chat-conversation tests pass (21).

Closes #7440

The ui-kit Textarea is a bare native <textarea> with no label, and the
placeholder is not a reliable accessible name (it vanishes on input and is
exposed to assistive tech inconsistently). Add a stable aria-label="Chat
message" independent of the placeholder prop, matching how the other
bare/icon-only controls in this codebase are labelled.

Closes JSONbored#7440
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 20, 2026
@loopover-orb

loopover-orb Bot commented Jul 20, 2026

Copy link
Copy Markdown

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-20 13:56:46 UTC

2 files · 1 AI reviewer · no blockers · readiness 98/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a small, correct accessibility fix: it adds a hardcoded aria-label="Chat message" to ChatComposer's bare Textarea and updates the test to assert the accessible name via getByRole with a name matcher, which pins the fix rather than just re-testing role presence. The implementation matches the codebase's stated convention for labeling bare/icon-only controls and correctly avoids conflating the label with the overridable placeholder prop. It closes #7440 and is narrowly scoped to exactly the described change.

Nits — 3 non-blocking
  • The three-line comment block in chat-composer.tsx:59-62 is fairly verbose for a one-line aria-label addition; a single-line comment would convey the same rationale.
  • Consider whether other bare-textarea/input instances in the miner-ui package have the same missing-accessible-name issue, since this PR only addresses ChatComposer.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #7440
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 175 registered-repo PR(s), 85 merged, 14 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jaytbarimbao-collab; Gittensor profile; 175 PR(s), 14 issue(s).
Improvement ℹ️ None detected risk: low · value: none
Review context
  • Author: jaytbarimbao-collab
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Rust
  • Official Gittensor activity: 175 PR(s), 14 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/ desktop before /
before /
after /
after /
/ mobile before / (mobile)
before / (mobile)
after / (mobile)
after / (mobile)

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

Scroll preview
Route Before (production) After (this PR's preview)
/ before / (scroll)
before / (scroll)

A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 20, 2026
@JSONbored
JSONbored merged commit 13e08fb into JSONbored:main Jul 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(miner-ui): ChatComposer's message textarea has no accessible name

2 participants