Skip to content

fix(mcp): register loopover_get_automation_state as a local stdio tool#7903

Closed
RealDiligent wants to merge 1 commit into
JSONbored:mainfrom
RealDiligent:feat/mcp-stdio-automation-state-7752
Closed

fix(mcp): register loopover_get_automation_state as a local stdio tool#7903
RealDiligent wants to merge 1 commit into
JSONbored:mainfrom
RealDiligent:feat/mcp-stdio-automation-state-7752

Conversation

@RealDiligent

Copy link
Copy Markdown
Contributor

Summary

Closes #7752.

Preflight (closed-PR failure modes checked)

Failure mode (from our recent closed PRs) Applied here
codecov/patch 0% on miner-lib .ts-only (#7889/#7882/#7795) Avoided — not a miner-lib PR; follows #7877 MCP stdio pattern
UI screenshot matrix incomplete (#7860/#7502/#7470) N/A — non-UI
One-shot: never push follow-up commits (#7827/#7812) Single commit; fresh branch; will not amend after open
Duplicate open PR on same issue (#7749/#7652/#7776) No open PR on #7752 (#7866 already closed)
Critical race / stale closure (#7506) N/A — registration only
Secrets-scan >512KB (#7431) Small additive patch on existing bin/*.ts
Base conflicts (#7830) Rebased onto current origin/main before open
Prior attempt #7866 closed for codecov/patch + validate-tests-merge Same shape as merged #7877 (tests + count pin); CI builds mcp before coverage

Test plan

  • npm run build:mcp
  • vitest run test/unit/mcp-cli-maintain-tools.test.ts test/unit/mcp-tool-rename-aliases.test.ts — 29/29 pass
  • CI validate-code / validate-tests / validate-tests-merge green

@RealDiligent
RealDiligent requested a review from JSONbored as a code owner July 21, 2026 16:49
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.60%. Comparing base (b3e1bc3) to head (455de14).

Files with missing lines Patch % Lines
packages/loopover-mcp/bin/loopover-mcp.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7903       +/-   ##
===========================================
+ Coverage   58.78%   80.60%   +21.81%     
===========================================
  Files         730       89      -641     
  Lines       74842    23385    -51457     
  Branches    22839     4515    -18324     
===========================================
- Hits        43999    18849    -25150     
+ Misses      27180     4358    -22822     
+ Partials     3663      178     -3485     
Flag Coverage Δ
shard-1 0.00% <0.00%> (?)
shard-2 0.00% <0.00%> (-46.90%) ⬇️
shard-3 0.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/loopover-mcp/bin/loopover-mcp.ts 0.00% <0.00%> (-13.30%) ⬇️

... and 641 files with indirect coverage changes

Mirror the maintain-family registerStdioTool pattern (JSONbored#6382/JSONbored#7877) and reuse
the same REST endpoint the existing `maintain automation-state` CLI already
calls. Bump the stdio tool-count invariant to 83 (correcting the stale pin
left after JSONbored#7887).

Closes JSONbored#7752.

Co-authored-by: Cursor <cursoragent@cursor.com>
@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 21, 2026
@loopover-orb

loopover-orb Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Caution

🛑 LoopOver review result - fixes required

Review updated: 2026-07-21 16:55:13 UTC

3 files · 1 AI reviewer · no blockers · CI failing · unstable

🛑 Suggested Action - Fix Blockers

Review summary
This PR registers loopover_get_automation_state as a new stdio MCP tool, following the same registerStdioTool/ownerRepoShape/apiGet pattern as sibling maintain tools, reuses the existing REST endpoint, and updates the tool-count invariant tests from 81 to 83. The diff is coherent with its stated intent (closes #7752), mirrors the merged #7877 pattern, and the test changes (new fixture regex, new MAINTAIN_TOOLS entry, updated counts/comments) look consistent with the new registration.

Nits — 5 non-blocking

CI checks failing

  • codecov/patch — 0.00% of diff hit (target 99.00%)

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #7752
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 387 registered-repo PR(s), 179 merged, 36 issue(s).
Contributor context ✅ Confirmed Gittensor contributor RealDiligent; Gittensor profile; 387 PR(s), 36 issue(s).
Improvement ✅ Minor risk: clean · value: minor · LLM: minor
Linked issue satisfaction

Addressed
The PR registers loopover_get_automation_state via registerStdioTool mirroring the sibling pattern, reuses apiGet against the same automation-state endpoint the CLI command calls, and adds its description through stdioToolDescription rather than inline, with accompanying test coverage bumping the tool count.

Review context
  • Author: RealDiligent
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, JavaScript, Ruby, Svelte, TypeScript, Markdown, MDX
  • Official Gittensor activity: 387 PR(s), 36 issue(s).
  • Related work: Titles/paths share 6 meaningful terms. (PR #7902)
  • Related work: Titles/paths share 6 meaningful terms. (PR #7901)
  • Related work: Titles/paths share 7 meaningful terms. (PR #7902, PR #7901)
Contributor next steps
  • Start here: Review top overlaps.
  • Then work through the remaining 2 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb

loopover-orb Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

LoopOver is closing this pull request on the maintainer's behalf (CI is failing (codecov/patch)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

@loopover-orb loopover-orb Bot closed this Jul 21, 2026
loopover-orb Bot pushed a commit that referenced this pull request Jul 21, 2026
…shot (#7917)

* feat(mcp): add remote + stdio surfaces for loopover_get_registry_snapshot

Mirror loopover_get_registry_changes on both the remote MCP server and local
stdio wrapper. Cover found/not-found remotely and instrument the bin via the
#7764 in-process exported-server pattern so codecov/patch sees the new lines
(unlike bin-only #7903).

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(test): rewrite mcp-cli-activation-preview for post-#7764 in-process connect

The StdioServerTransport mock deadlocks once another suite imports the bin
first (runAsCliEntrypoint is false). Use exported server + InMemoryTransport
like mcp-cli-plan-issues / registry-snapshot so validate-tests can share the
module across shards.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Register loopover_get_automation_state as a local stdio MCP tool

1 participant