Skip to content

feat(mcp): add remote + stdio surfaces for loopover_get_ams_miner_cohort#7935

Merged
loopover-orb[bot] merged 3 commits into
JSONbored:mainfrom
RealDiligent:feat/mcp-ams-miner-cohort-7797-v2
Jul 21, 2026
Merged

feat(mcp): add remote + stdio surfaces for loopover_get_ams_miner_cohort#7935
loopover-orb[bot] merged 3 commits into
JSONbored:mainfrom
RealDiligent:feat/mcp-ams-miner-cohort-7797-v2

Conversation

@RealDiligent

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • vitest mcp-cli-ams-miner-cohort + mcp-output-schemas + mcp-tool-rename-aliases (62 passed)
  • CI validate / validate-tests green
  • codecov/patch (all shards upload)

Made with Cursor

@RealDiligent
RealDiligent requested a review from JSONbored as a code owner July 21, 2026 19:17
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

Mirror loopover_get_maintainer_noise on both the remote MCP server and local
stdio wrapper. Cover authorized/forbidden remotely and instrument the bin via
the JSONbored#7764 in-process exported-server pattern so codecov/patch sees the new lines.

Closes JSONbored#7797

Co-authored-by: Cursor <cursoragent@cursor.com>
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.51%. Comparing base (c6d28ab) to head (01ee047).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7935       +/-   ##
===========================================
+ Coverage   65.46%   82.51%   +17.05%     
===========================================
  Files         733       90      -643     
  Lines       75133    24445    -50688     
  Branches    22918     4700    -18218     
===========================================
- Hits        49183    20170    -29013     
+ Misses      22166     4039    -18127     
+ Partials     3784      236     -3548     
Flag Coverage Δ
shard-1 22.81% <30.00%> (?)
shard-2 22.22% <30.00%> (?)
shard-3 33.20% <100.00%> (-23.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/loopover-mcp/bin/loopover-mcp.ts 14.06% <100.00%> (+2.50%) ⬆️
src/mcp/server.ts 96.66% <100.00%> (+31.69%) ⬆️

... and 643 files with indirect coverage changes

…tch coverage

codecov/patch failed at 90.9% on a single partial ternary in getAmsMinerCohort.
Use one summary template so the structured present flag remains the source of truth.

Co-authored-by: Cursor <cursoragent@cursor.com>
@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 21, 2026
Shards 2/3 tests passed; tokenless Codecov coverage upload failed GPG key fetch.

Co-authored-by: Cursor <cursoragent@cursor.com>
@loopover-orb

loopover-orb Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-21 19:48:18 UTC

7 files · 1 AI reviewer · no blockers · readiness 82/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
The AI review returned non-blocking notes for this change but did not include a separate narrative summary. Review the nits below before deciding this PR.

Nits — 3 non-blocking
  • packages/loopover-mcp/bin/loopover-mcp.ts:1584 uses an explicit `any` for the stdio handler args (`{ owner, repo }: any`) — the sibling stdio tools in this file follow the same pre-existing pattern, but `ownerRepoShape` itself is fully typed, so `{ owner, repo }: { owner: string; repo: string }` would be free type safety.
  • The PR description flags codecov/patch failing at 30% vs a 99% target — the diff itself looks fully covered by the new authorized/forbidden/stdio tests, so this is likely test files not counting toward `src/**` patch coverage rather than a real gap, but worth double-checking the coverage report names the exact uncovered lines in `src/mcp/server.ts` or `bin/loopover-mcp.ts`.
  • Possible secret-shaped assignment in the diff (generic_secret_assignment) — Verify the value is not a real credential.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #7797, #7930
Related work ⚠️ 1 scoped overlap Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (2 linked issues).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 395 registered-repo PR(s), 173 merged, 36 issue(s).
Contributor context ✅ Confirmed Gittensor contributor RealDiligent; Gittensor profile; 395 PR(s), 36 issue(s).
Improvement ✅ Minor risk: clean · value: minor
Review context
  • Author: RealDiligent
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, JavaScript, Ruby, Svelte, TypeScript, Markdown, MDX
  • Official Gittensor activity: 395 PR(s), 36 issue(s).
  • Related work: Titles/paths share 9 meaningful terms. (PR #7936)
Contributor next steps
  • Start here: Review top overlaps.
  • Then work through the remaining 2 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 4f87f1a into JSONbored:main Jul 21, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

loopover_get_ams_miner_cohort has a REST route but no remote MCP tool or local stdio MCP tool

1 participant