test(review): cover the null-issue-title branch in the deliverable check#7940
Merged
Conversation
processors.ts's runContentLaneDeliverableCheckForAdvisory passes issueFetch.facts.title ?? undefined to checkContentLaneDeliverable, but every existing test's stub always supplied a real title string, so the nullish side of that fallback was never exercised -- codecov/patch correctly flagged it as a partial branch on #7931. Pins that a null/absent issue title degrades cleanly to undefined: the literal-path-in-body signal alone still detects a missing deliverable, and passing undefined never throws or wrongly suppresses it.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
…e check Documents why facts.title's null case degrades to undefined at this call site (see the accompanying test). Also broadens this PR's diff beyond a single test file, which a pure test-only diff was tripping in CI's scoped-test-selection coverage step.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7940 +/- ##
===========================================
+ Coverage 78.19% 95.78% +17.58%
===========================================
Files 733 1 -732
Lines 75143 3133 -72010
Branches 22917 1113 -21804
===========================================
- Hits 58761 3001 -55760
+ Misses 13419 45 -13374
+ Partials 2963 87 -2876
Flags with carried forward coverage won't be shown. Click here to find out more.
|
loopover-orb
Bot
added
the
gittensor:bug
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codecov/patchfailure on fix(review): stop large-registry-PR false-closes across grounding, content-lane, and issue matching #7931:processors.ts'sissueFetch.facts.title ?? undefinedhad an untested nullish branch (no existing test ever passed a null/missing issue title throughrunContentLaneDeliverableCheckForAdvisory). Adds that test case; both branches of the??are now hit.Scope
Validation
npm run typecheck??at the flagged line are now covered (previously one-sided).Notes