fix(ghosthound): accept directories for --output - #17
Open
JVBotelho wants to merge 2 commits into
Open
Conversation
Move output path resolution and display after the NTLM check. This prevents unnecessary work and output if NTLM authentication is disabled, as the program would exit early.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--output0600on new and reused output files on Unix before truncationDesign decision
--outputtreats an existing directory as a request for<directory>/ghosthound_output.json; otherwise it treats the value as an explicit file path. A missing path ending in a directory separator is rejected as a missing directory. Parent directories are never created implicitly.This stays in the
ghosthoundCLI crate and does not change the LDAP or OpenGraph libraries. The decision is recorded here rather than in a new ADR because it is a CLI contract, not a structural architecture decision.Validation
cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test --all-targets --all-featurescargo test -p ad-secdesc-oraclecargo deny checkCloses #16