test(agama): add transpiler subflow and web-interaction codegen conformance tests#14486
Open
imran-ishaq wants to merge 2 commits into
Open
test(agama): add transpiler subflow and web-interaction codegen conformance tests#14486imran-ishaq wants to merge 2 commits into
imran-ishaq wants to merge 2 commits into
Conversation
…rmance tests Signed-off-by: imran <imranishaq7071@gmail.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChangesTranspiler conformance tests
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
imran-ishaq
marked this pull request as ready for review
July 6, 2026 13:44
…sting pass files instead of inline Java Signed-off-by: imran <imranishaq7071@gmail.com>
|
jgomer2001
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Prepare
Description
Adds
WebInteractionTestto the Agama transpiler module. It transpiles a flow usingTrigger(subflow),RRFandRFAC, and asserts the generated JavaScript contains the corresponding runtime calls (subflow call with result propagation, render-reply-fetch, redirect-fetch-at-callback). Registered in the module's TestNG suite. No production change - confirms current code generation conforms to the language reference.Target issue
The transpiler's Trigger (subflow), RRF and RFAC constructs are covered only by syntax-pass tests; nothing asserts they generate the expected runtime calls (subflow invocation with result propagation, render-reply-fetch, redirect-fetch-at-callback), so a code-generation regression could go unnoticed.
closes #14485
Implementation Details
agama/transpiler/src/test/java/io/jans/agama/test/WebInteractionTest.javausingTranspiler.transpileandasserting on the generated code.
agama/transpiler/src/test/resources/testng.xml.Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:to indicate documentation changes or if the below checklist is not selected.Summary by CodeRabbit