[feature] Warn when a key_ref file is group- or world-readable(#99) - #107
Open
Maedza wants to merge 1 commit into
Open
[feature] Warn when a key_ref file is group- or world-readable(#99)#107Maedza wants to merge 1 commit into
Maedza wants to merge 1 commit into
Conversation
Maedza
changed the title
Maedza
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
key_ref: file:PATHnow stat-checks the key file before reading and warns (once per path per process, POSIX-only) when it is group- or world-readable.Why
A permissive key file was previously used silently, despite
ARCHITECTURE.mdspecifying0600permissions. The change warns rather than fails so an operator who accepted the risk is informed, not broken.Fixes #99.
Test plan
make test: 499 passed, 17 skipped (live/model).git diff --checkclean.Checklist
make testpasses (hermetic suite; HTTP is mocked).CHANGELOG.md[Unreleased]updated.key_refreferences only, never a raw key.