Skip to content

Update ESP flasher stubs to v1.2.2 - #86

Merged
Jason2866 merged 1 commit into
factoryfrom
agents/update-esp-flasher-stubs-to-latest
Aug 25, 2026
Merged

Update ESP flasher stubs to v1.2.2#86
Jason2866 merged 1 commit into
factoryfrom
agents/update-esp-flasher-stubs-to-latest

Conversation

@Jason2866

@Jason2866 Jason2866 commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features
    • Added flasher support for ESP32-H4 and ESP32-P4 revision 1 devices.
  • Bug Fixes
    • Updated ESP32-P4 revision detection and stub selection for earlier revisions.
    • Refreshed flasher support across ESP32, ESP8266, and ESP32-S2/S3/C2/C3/C5/C6/C61/H2/P4 devices.
    • Improved ESP32-S3 NAND flashing support with updated plugin handling.
    • Replaced outdated device-specific flashing firmware images and memory configurations.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 65d3ba42-1f37-479b-a9ad-be17890b0009

📥 Commits

Reviewing files that changed from the base of the PR and between 392e71b and f389266.

📒 Files selected for processing (16)
  • esp_flasher/own_esptool.py
  • esp_flasher/stubs/esp32.json
  • esp_flasher/stubs/esp32c2.json
  • esp_flasher/stubs/esp32c3.json
  • esp_flasher/stubs/esp32c5.json
  • esp_flasher/stubs/esp32c6.json
  • esp_flasher/stubs/esp32c61.json
  • esp_flasher/stubs/esp32h2.json
  • esp_flasher/stubs/esp32h4.json
  • esp_flasher/stubs/esp32p4-rev1.json
  • esp_flasher/stubs/esp32p4.json
  • esp_flasher/stubs/esp32p4rc1.json
  • esp_flasher/stubs/esp32s2.json
  • esp_flasher/stubs/esp32s3.json
  • esp_flasher/stubs/esp32s31.json
  • esp_flasher/stubs/esp8266.json
💤 Files with no reviewable changes (1)
  • esp_flasher/stubs/esp32p4rc1.json

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The flasher updates stub firmware metadata and encoded payloads for multiple ESP32 variants. It adds ESP32-H4 and ESP32-P4 rev1 definitions, updates ESP32-S3 NAND plugin data, and routes older ESP32-P4 revisions to the new rev1 stub.

Changes

Flasher stub refresh

Layer / File(s) Summary
Chip stub image updates
esp_flasher/stubs/esp32.json, esp_flasher/stubs/esp32c*.json, esp_flasher/stubs/esp32h*.json, esp_flasher/stubs/esp32p4.json, esp_flasher/stubs/esp32s2.json, esp_flasher/stubs/esp32s31.json, esp_flasher/stubs/esp8266.json
Updated entry points, encoded text and data payloads, and memory layout addresses. Added the ESP32-H4 stub definition.
ESP32-S3 NAND stub
esp_flasher/stubs/esp32s3.json
Updated the firmware payload, memory metadata, NAND plugin configuration, and opcode handler mappings.
ESP32-P4 rev1 routing
esp_flasher/own_esptool.py, esp_flasher/stubs/esp32p4-rev1.json, esp_flasher/stubs/esp32p4rc1.json
Added the ESP32-P4 rev1 stub, removed the previous RC1 stub definition, and changed older-revision selection and RC1 registration to use esp32p4-rev1.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk: ⚪ Minimal · up to f3892

This PR updates ESP flasher stub definitions and introduces no actionable merge-blocking risk based on the available evidence; it is merge-ready after normal checks and review.

Poem

A rabbit checks the stubs at dawn
New bytes hop where old ones yawn
H4 joins the flashing trail
P4 rev1 sets its sail
NAND maps receive their tune
Every chip gets code anew

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (14 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: updating the ESP flasher stubs to version 1.2.2.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (14 skipped: 14 unsupported.)

✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agents/update-esp-flasher-stubs-to-latest

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Jason2866
Jason2866 merged commit f69be30 into factory Aug 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant