Run CI on main and on stacked pull requests - #24
Merged
Merged
Conversation
The workflow only triggered on `pull_request` with base `main`, which left two gaps that combined to let an unverified merge through. main was never tested directly. Nothing runs on push, so anything that reaches main by another route — a merge whose checks had not finished, a direct push — is unverified. That is how PRs #22 and #23 landed without a single check run. And the `branches: [main]` filter skips stacked pull requests: a PR based on another feature branch does not match, so it gets no checks at all. Those are exactly the changes that most want verifying, since they land on top of an unmerged base. Dropping the filter covers them; `push` stays pinned to main so a PR branch does not run twice. Also adds workflow_dispatch, so main can be re-checked on demand rather than needing a throwaway PR. Verified locally against merged main, reproducing all four steps — host tests, clippy, and the wasm suite under both Firefox and Chrome. That needed wasm-bindgen-cli 0.2.105 to match Cargo.lock; a newer global install fails with a schema mismatch, which is what the existing comment on the wasm-bindgen-action version is warning about. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #22/#23, which both merged without a single check run. This closes the two gaps that allowed it.
What went wrong
rust.ymltriggered only onpull_requestwithbranches: [main].mainis never tested. There is nopushtrigger, so anything reachingmainby another route is unverified. The run history showsCode checking and unit testingfiring formodernize-example-app(Rebuild the example site as a bleeding-edge dwind/dominator showcase #21) and then nothing for Let dwind express keyframes, pseudo-elements and arbitrary declarations #22 or Delete the example's stylesheet #23 — the pushes tomainonly triggered the Pages deploy.branches: [main]. Let dwind express keyframes, pseudo-elements and arbitrary declarations #22 was based onmodernize-example-appand Delete the example's stylesheet #23 ondwind-keyframes-and-arbitrary-values, so neither ever qualified. They were retargeted tomainshortly before merge, which is too late for checks to run.The changes that most want verifying are the stacked ones, since they land on top of an unmerged base.
The change
pushstays pinned tomain, so a PR branch in this repo doesn't run twice.workflow_dispatchmeansmaincan be re-checked on demand instead of needing a throwaway PR.Verification
The workflow was run locally against merged
main, reproducing all four steps:cargo test(host)cargo clippyTwo notes from doing that, both worth knowing for anyone reproducing CI locally:
wasm-bindgen-cli0.2.105 to matchCargo.lock. A newer global install fails with a bindgen schema mismatch — which is exactly what the existing comment on thewasm-bindgen-actionversion pin is warning about.wasm-pack testmasks this by managing its own matching copy, so the barecargo test --target wasm32-unknown-unknownthat CI runs is the stricter check.This PR is itself the first test of the new trigger: opening it should produce a check run.
🤖 Generated with Claude Code