Feat team style#10
Conversation
material/color/name живут в config.yml: teamselect.teams.<n>, единый источник правды для GUI выбора, лобби-скорборда и режимов. Добавлен публичный API TeamStyle/TeamStyleProvider — моды читают стили оттуда вместо хардкода. v4-миграция: переносит имена из messages.yml: ui.teamselect.teams.<n>.name в config.yml: teamselect.teams.<n>.name (если в config ещё нет), затем вырезает legacy-секцию из messages.yml. Existing моды визуально не меняются. Voicechat-интеграция (TeamGroupManager) использует новый API для имени команды вместо собственного парсера messages.yml. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 621a635cd4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| val candidates = mutableSetOf<UUID>() | ||
| candidates += instance.getActivePlayerIds() | ||
| for (team in instance.teams) for (p in team) candidates += p.uniqueId |
There was a problem hiding this comment.
When a mode clears instance.teams at match start (the new comments explicitly allow this) and participants are removed one by one, GameInstanceEndedEvent is fired only after activePlayerIds has already been emptied, so this candidate set can be empty. In that scenario no online players are moved out of the SimpleVoiceChat groups, leaving them isolated in the old team group after the match/lobby transition. Store the UUIDs assigned in groupsByInstance and use that snapshot during dissolve instead of relying on the already-cleared instance state.
Useful? React with 👍 / 👎.
1 participant
No description provided.