Long paths#4
Merged
Merged
Conversation
JuJuz1
commented
Jun 11, 2026
JuJuz1
commented
Owner
- Introduce memory arenas to manage allocated fixed amount of heap memory
- AppState and UIJob paths now use permanent storage allocated at startup
- Paths are extended to hold 32 767 bytes. See: https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry
- This structure allows arbitrary lengths as we can precisely measure how much memory is needed for the whole app
Introduced arenas to control the permanent memory storage as well as scratch memory. We now just preallocate a large enough buffer for all paths in AppState and UIJob. Arenas are meant to handle that memory more cleanly as well as help debugging memory usage. Tests still use stack space with regards to paths but that will probably change
LLM generated, seems good though and covers a lot of cases
Tests failed due to VirtualAlloc failing because it had a fixed address in dev builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.