Skip to content

CHOLMOD: Prefer RefValue to Ref for fields and type-assertions #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
araujoms merged 1 commit into from
Sep 3, 2026
Merged

CHOLMOD: Prefer RefValue to Ref for fields and type-assertions #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/solvers/cholmod.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,12 +173,12 @@ end

function getcommon(::Type{Int32})
LibSuiteSparse.init_suitesparse()
return get!(newcommon, task_local_storage(), :cholmod_common)::Ref{cholmod_common}
return get!(newcommon, task_local_storage(), :cholmod_common)::Base.RefValue{cholmod_common}
end

function getcommon(::Type{Int64})
LibSuiteSparse.init_suitesparse()
return get!(newcommon_l, task_local_storage(), :cholmod_common_l)::Ref{cholmod_common}
return get!(newcommon_l, task_local_storage(), :cholmod_common_l)::Base.RefValue{cholmod_common}
end

getcommon() = getcommon(Int)
Expand Down Expand Up @@ -264,9 +264,9 @@ mutable struct Factor{Tv<:VTypes, Ti<:ITypes} <: Factorization{Tv}
ptr::Ptr{cholmod_factor}
dense_x::cholmod_dense_struct
dense_b::cholmod_dense_struct
X::Ref{Ptr{cholmod_dense_struct}}
Y::Ref{Ptr{cholmod_dense_struct}}
E::Ref{Ptr{cholmod_dense_struct}}
X::Base.RefValue{Ptr{cholmod_dense_struct}}
Y::Base.RefValue{Ptr{cholmod_dense_struct}}
E::Base.RefValue{Ptr{cholmod_dense_struct}}
lock::ReentrantLock
function Factor{Tv, Ti}(ptr::Ptr{cholmod_factor}, register_finalizer = true) where {Tv, Ti}
if ptr == C_NULL
Expand Down
6 changes: 6 additions & 0 deletions test/cholmod.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,12 @@ end
end #end for Ti ∈ itypes

for Tv ∈ (Float32, Float64)
@testset "per-type buffers should be concretely typed" begin
@test @inferred(SparseArrays.CHOLMOD.getcommon()) isa Base.RefValue
F = cholesky(sparse(Tv[2 1; 1 2]))
@test @inferred((F -> getfield(F, :Y)[])(F)) isa Ptr
end

@testset "Issue #9915" begin
sparseI = sparse(Tv(1.0)I, 2, 2)
@test sparseI \ sparseI == sparseI
Expand Down
Loading