SPQR: build factors with typed constructors, for type-stability - #756
Open
topolarity wants to merge 1 commit into
Open
SPQR: build factors with typed constructors, for type-stability#756topolarity wants to merge 1 commit into
topolarity wants to merge 1 commit into
Conversation
`qr` wrapped SPQR's result pointers with the untyped `Sparse(ptr)` and `Dense(ptr)` constructors, which read the element type from the C struct and so dispatch dynamically. SPQR computes in double precision whatever the input type, so the result type is known: map it from the input element type and use the typed constructors. This commit was written with the assistance of generative AI (Claude). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
==========================================
- Coverage 83.85% 83.81% -0.04%
==========================================
Files 13 13
Lines 9387 9390 +3
==========================================
- Hits 7871 7870 -1
- Misses 1516 1520 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Wait, why does the function accept |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last PR of the
--trimset!Having the types spelled out explicitly here allows these constructors to be fully inferred w.r.t. dispatch. This does not affect the return type of any call, so no
@inferredtest is included.This commit was written with the assistance of generative AI (Claude) 🤖