Fix HTTP auto fallback on h2 ALPN rejection#1269
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1269 +/- ##
==========================================
+ Coverage 84.36% 84.53% +0.16%
==========================================
Files 28 28
Lines 10689 10690 +1
==========================================
+ Hits 9018 9037 +19
+ Misses 1671 1653 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d626d49 to
549a810
Compare
549a810 to
9efb50b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http/1.1alongsideh2for the default high-levelprotocol=:autoh2 probeprotocol=:h2strict and continue honoring user-specified ALPN lists verbatimRoot Cause
protocol=:autoattempted h2 with a default ALPN list of only["h2"]. Some h1-only servers reject that during TLS withno_application_protocolbefore HTTP can observe an ALPN mismatch and run the existing h1 fallback.The Windows CI failures on the first drafts resolved
Reseau v1.1.3and exposed unrelated test harness races: redirect test servers sentConnection: closeresponses for POST requests without draining the request body, which can reset the TCP connection on Windows.Validation
julia --project=. --startup-file=no --history-file=no -e 'using Pkg; Pkg.test(; test_args=["http_integration_tests.jl", "http2_client_tests.jl"])'(test driver ran the full suite)julia --project=. --startup-file=no --history-file=no test/http_client_tests.jljulia --project=. --startup-file=no --history-file=no test/http_parity_tests.jlprotocol=:autoreturns200over HTTP/1.1Refs #1265
Co-authored by Codex