Rename app icon to match the manifest id - #3
Open
MohammedSalem2510 wants to merge 1 commit into
Open
Conversation
DeskThing resolves an app's icon by id: getIcon in
DeskThingServer/src/main/services/apps/appUtils.ts builds the path as
join(getAppFilePath(appName), 'icons', icon || `${appName}.svg`), and
the client builds /icons/<appId>/icons/<appId>.svg.
The repo ships icons/deskthingapp.svg (the template default) while the
manifest id is "streamthingy", so the lookup for icons/streamthingy.svg
never resolves and getIcon returns null. AppManifest has no icon field,
so the filename is the only way to bind an icon to the app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeskThing resolves an app's icon by id: getIcon in DeskThingServer/src/main/services/apps/appUtils.ts builds the path as join(getAppFilePath(appName), 'icons', icon ||
${appName}.svg), and the client builds /icons//icons/.svg.The repo ships icons/deskthingapp.svg (the template default) while the manifest id is "streamthingy", so the lookup for icons/streamthingy.svg never resolves and getIcon returns null. AppManifest has no icon field, so the filename is the only way to bind an icon to the app.