Add regression tests for image language fallback selection - #2
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Add regression tests for image language fallback selection#2devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Add xUnit test project (EmbyImageLanguageFallback.Tests) - 74 tests covering BuildFallbackSelection, NormalizeLanguage, IsLanguageNeutral, LanguageMatches, RewriteSelectedFallbackImages, and PluginOptions language canonicalization - Tests verify fallback chain: primary -> fallback -> neutral - Tests cover missing primary/fallback scenarios, language alias matching (zh/ja/en variants), deduplication, and rewrite behavior - Exclude test directory from main project compilation Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an xUnit test project (
EmbyImageLanguageFallback.Tests) with 74 regression tests that verify the core image language fallback selection logic. Tests use reflection to invoke private methods onFallbackRemoteImageProviderwithout modifying the production API surface.Test coverage includes:
BuildFallbackSelection— the core fallback chain (primary → fallback → neutral):IsLanguageNeutral— null, empty, whitespace, "null", and "00" are neutral; real language codes are notNormalizeLanguage— maps aliases to canonical forms (e.g., "chinese" → "zh-Hans", "jpn" → "ja")LanguageMatches— case-insensitive matching, display language fallback behaviorRewriteSelectedFallbackImages— fallback images rewritten to English, primary images preservedPluginOptions.GetCanonicalLanguageValue/GetLanguageAliases— canonical resolution and alias expansionChanges to main project:
DefaultItemExcludestoEmbyImageLanguageFallback.csprojto prevent the test directory from being compiled into the main project (standard SDK-style project layout fix)Review & Testing Checklist for Human
dotnet test EmbyImageLanguageFallback.Tests/and verify all 74 tests passdotnet build EmbyImageLanguageFallback.csprojDefaultItemExcludeschange doesn't affect the main project's compiled outputNotes
FormatterServices.GetUninitializedObjectto createFallbackRemoteImageProviderinstances without calling the constructor (avoids Emby DI dependencies). The SYSLIB0050 warning for this obsolete API is suppressed in the test project only..csprojexclude and the solution file were updated.Link to Devin session: https://app.devin.ai/sessions/2e10bf48b0e649a6a2667d1359b78c49
Requested by: @JustDreemurr