Skip to content

fix(v4): move hot rows16 packing out of store mutex - #983

Open
aniketshukla1 wants to merge 1 commit into
JustVugg:devfrom
aniketshukla1:fix/900-hot-pack-locking
Open

fix(v4): move hot rows16 packing out of store mutex#983
aniketshukla1 wants to merge 1 commit into
JustVugg:devfrom
aniketshukla1:fix/900-hot-pack-locking

Conversation

@aniketshukla1

@aniketshukla1 aniketshukla1 commented Aug 12, 2026

Copy link
Copy Markdown

Summary

  • Move rows16 packing behind a per-slot preparation mutex instead of the store-wide mutex.
  • Convert in place only while the requesting lease is exclusive; an existing row-major view keeps its layout until a later lookup can safely repack the slot.
  • Publish the packed state under the store mutex, so consumers of the same slot wait while unrelated expert loads continue.
  • Add a hot-store regression test that verifies deferred conversion and concurrent packed lookups; it is part of make check.

Validation

  • make check
  • make tests/test_deepseek_v4_hot_store && ./tests/test_deepseek_v4_hot_store

Resolves #900

@aniketshukla1
aniketshukla1 force-pushed the fix/900-hot-pack-locking branch from 1148f00 to bd5cc22 Compare August 12, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant