fix: GAP-3 余量收口——审计驱动的最小修复(InkAsyncSlot 判 YAGNI)#199
Merged
Conversation
审计(24 站点逐判):A 类真吞错仅 1 因——canvasLaneDirectionProvider 漏出 _EdgeLaneErrorSlot watch 范围(方向静默回落 horizontal,且 lane_toolbar 会基于 错误基线写库反向覆盖用户已存方向);并入横幅 watch 链。顺手:全库唯一 raw toString 上屏点(_LoadError)改走 l10nAsyncError;InkErrorBanner.onRetry 死参数删除(从未渲染、零调用方);B 类良性降级 4 站点加横幅指向注释。 InkAsyncSlot 共享件判 YAGNI:列表槽位 LB-06 已全收口,0 个真实站点。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
P2-3:base style 编辑器读失败改为提示并中止(此前空预填,保存即把已存前后缀 覆盖为空——自由文本域无护栏,真实损毁面)。P2-2:raw toString 断言改 InkError(/local_io_error(此前 'LocalIOError' 与 toString 格式不符,零区分度)。 P2-1:「绝迹/唯一」宣称收窄——设置页探测诊断行 raw 异常文本为有意例外并注明。 P3:lane_toolbar 措辞纠偏(二元域无损毁)+置灰/遮蔽/无日志三条记债。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
Author
|
对抗评审结论 APPROVE(无 P1),P2×3 全部落地:
复验:analyze 0;全套 1697 通过。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GAP-3(AsyncValue error 态统一)余量按逐站点审计收口(24 个 widget 侧站点全判:A 真吞错 / B 良性降级 / C 非槽位特例):
canvasLaneDirectionProvider漏出_EdgeLaneErrorSlot的 watch 范围——方向读失败静默回落 horizontal,泳道按错误方向渲染;更糟的是 lane_toolbar 会基于错误基线把「翻转后的默认值」写库,反向覆盖用户已存方向。修复=方向 error 并入既有横幅链_LoadError(message: err.toString())是全库唯一 raw toString 上屏点,改走l10nAsyncError(i18n 零硬编码规则)InkErrorBanner.onRetry从未渲染、零调用方传参——删除(重试按钮由各站点按需自置,骨架只管呈现)测试:方向失败→横幅(此前无任何提示);节点失败→l10n 文案且断言 raw toString 绝不上屏;PL-4a 组补方向密封。
Test plan
🤖 Generated with Claude Code