feat: GAP-1 设置页 Custom Provider 编辑 UI——上线前必做清单最后一卡#200
Merged
Conversation
CustomProviderStore(list/upsert/remove):raw 条目保真——非法条目原位保留; 损坏文件拒写 LocalIOError 绝不覆盖;.partial→rename 原子写 pretty JSON; 写不触会话内快照(重启生效边界)。字段校验抽 core 纯函数,服务解析与 设置页内联共用同一事实源;_parseEntry 改用共享校验(告警语义不变)。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
列表+5 字段表单对话框(校验=共享纯函数,内联报错不提交)+删除确认; 写后常驻「重启后生效」条;损坏文件列表呈现原因、写拒绝 snackbar。 ARB +23 键;api_keys custom:* 行显示 displayName;app_routing/golden 设置场景密封空 store。widget 测试 6 例 + api_keys 1 例。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
P2-1:upsert 原位替换改以旧 raw map 为基底合并——手编未知字段(_note 等) 不随 UI 编辑丢失,补保真测试。P2-2:写成功路径 invalidate 前补 context.mounted (失败路径已有,不对称;unmount 后 autoDispose 天然重建)。P3×5 记 BOARD 债。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
Author
|
对抗评审结论 APPROVE(无 P1),P2×2 已修、P3×5 记债:
复验:analyze 0;写侧 23 例含新保真测试;全套 1720 通过。CI test+coverage 已在上一轮全绿,本轮推送后再次一次性核验后合并。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
上线前必做第 7 条 GAP-1(L):手编 json+重启是 BYO-key 主打定位的体验硬伤——现在设置页可视化增删改,守住「重启生效」边界(不碰 registry 变异深水区):
写侧(Task 1)
CustomProviderStore(list/upsert/remove) 由 CustomProvidersFileService 一并实现——raw 条目保真:读侧剔除的非法/未知条目原位保留,编辑一条绝不销毁用户手编的坏条目.partial→rename 原子写 2 空格 pretty JSON 保持可手编UI(Task 2)
顺带修(Task 3,卡面明列):API Keys 行对
custom:*显示 capabilities.displayName(此前裸custom:<id>)验收对卡:不碰 json 完成增删改 ✓;非法输入内联报错 ✓;损坏 json 不崩(列表呈现原因+拒写保护)✓;重启后下拉出现=既有 bootstrap 链 ✓;fake Store widget 测试 ✓
Plan: docs/superpowers/plans/2026-07-18-gap-1-custom-providers-ui.md
Test plan
🤖 Generated with Claude Code