You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One grammar question: like GL_EXT_debug_printf, this extension doesn't actually define a syntactic path to allow a literal string in a function-call argument. The wording ("the first argument must be a literal string") suggests the string is a special argument rather than an expression; yet glslang parses strings as a primary-expression, so abortEXT(("foo")) is accepted by glslang even though nothing in this extension suggests that it should be.
So: what is actually intended here? I would like to know so that so that the grammar I have proposed in GL_EXT_spirv_intrinsics_string (#333) can be kept consistent with what GL_EXT_abort and GL_EXT_debug_printf do. Adding an explicit production to the extension text may be useful to remove any ambiguity.
Also, minor typo: "Last Modified Date" mentions "September 31, 2024", even though September has only 30 days.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @gnl21