バーコードのキー入力を常に消費して画面へ漏れないようにする - #55
Merged
Merged
Conversation
時間差判定をやめ、英数字と Enter は常にデコーダが消費する。 先頭1文字の漏れと、読み取り失敗時の Enter でボタンが起動する問題を解消。 サーバアドレスは QR からのみ設定する運用に合わせて入力欄を読み取り専用にした。
Contributor
UI差分settings_screen
settings_screen_install_not_permitted
settings_screen_up_to_date
settings_screen_update_available
settings_screen_update_check_failed
全画面スクリーンショットmain_screen
main_screen_account_result
main_screen_calculator
main_screen_calculator_shortage
main_screen_drawer
main_screen_empty
main_screen_error
main_screen_item_selection
main_screen_item_selection_failed
main_screen_item_selection_loading
main_screen_store_selection
main_screen_store_selection_failed
main_screen_store_selection_loading
settings_screen
settings_screen_install_not_permitted
settings_screen_up_to_date
settings_screen_update_available
settings_screen_update_check_failed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
前回の修正では、キー入力の間隔が 200ms 以内かどうかでバーコードリーダーからの入力かを判定していた。この方式には次の穴が残っていた。
タブレットでバーコードを読むとサイドバーが開くのはこれが原因。
変更内容
QR スキャンはカメラ経由でスキャン結果を直接反映しているため、入力欄の読み取り専用化の影響を受けず従来どおり動作する。
テスト
BarcodeKeyEventDecoderTest を新しい挙動に合わせて書き直した（21 ケース）。
Generated by Claude Code