Correct shared server documentation - #6
Draft
N1k0s1 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The documentation incorrectly claimed that the identity platform and its data were hosted on a dedicated server isolated from the rest of KiwiHacks infrastructure. The service actually shares a server with other KiwiHacks services, so the public security and privacy documentation was misleading.
This change makes the deployment description accurate without changing the existing access-control, audit-logging, or encryption claims.
Closes #5.
Validation
RAILS_ENV=test bundle exec rspec --pattern spec/requests/docs_spec.rb- 2 examples, 0 failuresbundle exec rubocop spec/requests/docs_spec.rb- no offensesbundle exec erb_lint app/views/docs/security.md.erb app/views/docs/privacy.md.erb- no errorsgit diff --check- passedThe full suite was also run: 251 of the pre-existing 287 examples passed. Its 36 unrelated failures are in identity-verification and authorization-view coverage, including missing local Active Record encryption credentials and stale Hack Club/KiwiHacks view expectations.